Warn user before closing when uploading a file on a upload only link #16984
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
rullzer,
skjnldsv,
ChristophWurst and
danxuliu
| @@ -120,6 +130,9 @@ | |||
| e.preventDefault(); | |||
| $('#public-upload #emptycontent input').focus().trigger('click'); | |||
| }); | |||
| window.onbeforeunload = function() { | |||
There was a problem hiding this comment.
From https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload#Syntax
Typically, it is better to use window.addEventListener() and the beforeunload event, instead of onbeforeunload.
There was a problem hiding this comment.
Ah yes! Especially since we remove inline scripts with csp :)
There was a problem hiding this comment.
Dunno. @juliushaertl which one should we use? :)
There was a problem hiding this comment.
I don't have a strong oppinion, this code is mainly a copy of what we use here:
server/apps/files/js/file-upload.js
Line 1291 in 07c3665
So I'd say lets get it in and we can cleanup if we might refactor at some point, as I don't see any downside of that code for now
|
Backport to 17? |
|
Yes, I'd say so. |
|
/backport to stable17 |
|
backport to stable17 in #17034 |
Make sure the browser shows a warning that a upload is still ongoing when uploading files though a drop only link.