Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly initialize the CacheJail for sharing #16985

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

juliusknorr
Copy link
Member

Replaces #16911

The set root path is expected to be an empty string instead of null when obtaining the jailed path in

if ($this->getRoot() === '') {

This fixes two issues when sharing a complete group folder:

Search:

  • Create a group folder and add some files to it
  • Share the whole group folder with another user or guest account
  • Search in the home folder for a file that exists in the groupfolder as user or guest
    💥 Filename not displayed properly and path is set wrong
    ✔️ File is displayed and linked properly

Activity:

  • Create a group folder and add some files to it
  • As admin share the whole group folder with a guest account
  • As a guest user upload a file to the group folder
    💥 The activity app for the admin shows a broken entry
    ✔️ The activity app for the admin shows the correct file entry

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@nickvergessen

This comment has been minimized.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 17 milestone Sep 4, 2019
@rullzer rullzer mentioned this pull request Sep 4, 2019
16 tasks
@rullzer rullzer modified the milestones: Nextcloud 17, Nextcloud 18 Sep 5, 2019
@rullzer
Copy link
Member

rullzer commented Sep 5, 2019

Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging.

@nickvergessen
Copy link
Member

/backport to stable17

@nickvergessen
Copy link
Member

/backport to stable16

@nickvergessen
Copy link
Member

/backport to stable15

@nickvergessen
Copy link
Member

Failures are unrelated

@nickvergessen nickvergessen merged commit 9268c0c into master Sep 9, 2019
@nickvergessen nickvergessen deleted the bugfix/noid/unjailed-share-path-v2 branch September 9, 2019 12:59
@backportbot-nextcloud
Copy link

backport to stable17 in #17060

@backportbot-nextcloud
Copy link

backport to stable16 in #17061

@backportbot-nextcloud
Copy link

backport to stable15 in #17062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants