Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run every possible DB combo on PRs #16990

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Sep 3, 2019

Only run them once merged.

I feel this is still more than enough DB coverage during regular PRs

Only run them once merged.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the ci/do_not_run_every_db_combo_on_prs branch from 247e800 to f4ab443 Compare September 3, 2019 18:16
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 3, 2019
@rullzer rullzer merged commit 102b1e1 into master Sep 4, 2019
@rullzer rullzer deleted the ci/do_not_run_every_db_combo_on_prs branch September 4, 2019 06:08
@rullzer rullzer mentioned this pull request Sep 4, 2019
16 tasks
@kesselb
Copy link
Contributor

kesselb commented Sep 4, 2019

Looks like a good candidate for a backport. Does that make sense?

@nickvergessen
Copy link
Member

Would need to be redone there because of the different php versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants