Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab navigation of menu in public share pages #17861

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Fix tab navigation of menu in public share pages #17861

merged 3 commits into from
Jan 7, 2020

Commits on Dec 30, 2019

  1. Change menu toggle element from span to button 

    This makes possible to navigate to the menu toggle using the keyboard,
as well as being semantically more correct.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    e32766b View commit details
    Browse the repository at this point in the history

  2. Format HTML elements 

    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    33b2f4e View commit details
    Browse the repository at this point in the history

  3. Split the menu entry for external shares in two 

    The external shares entry showed a "button" that, when pressed, replaced
the button with the input to set the remote share address. The "button"
was actually a label for the input, so when the label was focused it
transferred the focus to the input and thus pressing enter or space did
not show the input. Moreover, inputs inside links are not valid HTML,
and once shown there was no way to hide the input again.

Due to all this, and for consistency with the direct link input, the
external share input was moved to a different menu item that is shown
and hidden when the button, which nows is also a real button, is
clicked.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    883a71c View commit details
    Browse the repository at this point in the history