Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to accept (internal) shares by default #18385

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Allow users to accept (internal) shares by default #18385

merged 1 commit into from
Dec 17, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Dec 12, 2019 •
edited
Loading

Fixes #18255

Todo:

@rullzer rullzer added this to the Nextcloud 18 milestone Dec 12, 2019
@rullzer rullzer mentioned this pull request Dec 12, 2019
Closed
ChristophWurst
ChristophWurst reviewed Dec 13, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

event naming is not ideal IMO

lib/public/Share/Events/SharedEvent.php Outdated Show resolved Hide resolved
@wiswedel wiswedel mentioned this pull request Dec 13, 2019
Closed
@rullzer rullzer mentioned this pull request Dec 16, 2019
Merged
34 tasks
@rullzer rullzer force-pushed the fix/18255/user_setting_to_always_accept_share branch from e4a31eb to f4ca386 Compare December 16, 2019 09:10
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 16, 2019
ChristophWurst
ChristophWurst approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 17, 2019
@rullzer
Allow users to specify to accept (internal) shares by default
e7dc910 
Fixes #18255

A new user setting allows a user to always accept (internal) shares. For
example if they don't like accepting shares manually ;)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the fix/18255/user_setting_to_always_accept_share branch from 684d69f to e7dc910 Compare December 17, 2019 09:49
@ArtificialOwl
Copy link
Member

I just had a bad UX. True that I am not used to having to confirm for a shared file but:

  • there is only a (discret) red dot on the notification icon.
  • the shared file is displayed in the header as 'Recently shared' but clicking on the file does nothing as the file is not available in the folder/filetree. Maybe displaying a message to accept the share when clicking on the file.
  • we might add a popup in the middle of the screen saying that someone is sharing a file when a file is shared

@rullzer rullzer merged commit d3012bf into master Dec 17, 2019
@rullzer rullzer deleted the fix/18255/user_setting_to_always_accept_share branch December 17, 2019 11:02
@rullzer
Copy link
Member Author

rullzer commented Dec 17, 2019

@daita please create a separate issue

@rullzer rullzer mentioned this pull request Dec 17, 2019
Merged
This was referenced Dec 22, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: sharing
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.

No way to accept shares if notifications app is not enabled
4 participants
@rullzer @ArtificialOwl @ChristophWurst @skjnldsv