-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude groups from sharing: Skip delete groups #19124
Conversation
4736e72
to
fc006d2
Compare
fc006d2
to
3917dae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation seems off in the js file
576d828
to
8772a1e
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
8772a1e
to
16f29d8
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
/backport to stable18 |
/backport to stable17 |
Hmm. It seems I lost fc006d2 on rebase 🙈 |
New PR :) But I tested and the UI and all still worked. On the next save it will not bet there as well. So this is basically only a cleanup thing. |
Exactly. I will have a look later. |
Fix #13647
server/apps/settings/js/settings.js
Lines 58 to 60 in 0a24094
results.find
will return undefined if no group found hencedisplayname
fail. I don't know what's wrong with the indention. ESLint does not complain locally about the changes but the rest of the file seems to be wrong.