-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix three dots menu on mobile devices #19541
Conversation
Hey! :) Well, grid doesn't make sense here as you're not specifying any grid layout :/ |
What would be a more correct way for @acsfer to fix this in that case? :) (It does seem to fix the issue.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design-wise this looks good, except that title and subline are a bit pushed down – they should be centered vertically in the header.
But needs further code feedback from @skjnldsv about what would be the right way to implement this.
Can't dig into this in the next few days sorry. If @skjnldsv don't do, i'll do it next week. |
it have, the parent have a display inline-flex :) |
Ah right, confused myself! Thanks for the help :) The whole header should be a flex and the shrinkable area shuld only be the file name then, this is the expected behavior I think 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced by #20744
flex-wrap
has no effect here.Fixes #19479