-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure MySQL is not saying 'this' = 'this ' is true #20050
Conversation
Tried testing and to add to the amusement, MySQL 5.7
MySQL 8
|
Okay, so they fixed it for mysql8 on your machine? Im pretty sure I have 8 too locally and I could reproduce it there |
I just tested on
|
Okay, seems to be the case for me now too. MariaDB seems to be affected: MariaDB [(none)]> SELECT 'jan' = 'jan ', BINARY 'jan' = 'jan ';
+----------------+-----------------------+
| 'jan' = 'jan ' | BINARY 'jan' = 'jan ' |
+----------------+-----------------------+
| 1 | 0 |
+----------------+-----------------------+
1 row in set (0.00 sec)
MariaDB [(none)]> SELECT VERSION();
+----------------------------------+
| VERSION() |
+----------------------------------+
| 10.1.44-MariaDB-0ubuntu0.18.04.1 |
+----------------------------------+
1 row in set (0.00 sec) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense 👍
Conflicts :/ |
Let me fix them. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
cdeb084
to
16e9bf2
Compare
Basically this made my production instance do boom... I'll have to see why... but for now we can't really release beta3 with this... |
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
🍿🍿🍿🍿🍿🍿🍿🍿🍿🍿
100 popcorn, take one and have a look while I perform a magic trick: