-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow some apps to have root URLs in their own routing file #20114
Allow some apps to have root URLs in their own routing file #20114
Conversation
['name' => 'requesthandlercontroller#addShare', 'url' => '/ocm/shares', 'verb' => 'POST', 'app' => 'cloud_federation_api'], | ||
['name' => 'requesthandlercontroller#receiveNotification', 'url' => '/ocm/notifications', 'verb' => 'POST', 'app' => 'cloud_federation_api'], | ||
['name' => 'pagecontroller#showCall', 'url' => '/call/{token}', 'verb' => 'GET', 'app' => 'spreed'], | ||
['name' => 'pagecontroller#authenticatePassword', 'url' => '/call/{token}', 'verb' => 'POST', 'app' => 'spreed'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are now in nextcloud/spreed#3134
All other apps are in this PR
@@ -98,42 +106,7 @@ public function register() { | |||
private function processOCS(array $routes): void { | |||
$ocsRoutes = $routes['ocs'] ?? []; | |||
foreach ($ocsRoutes as $ocsRoute) { | |||
$name = $ocsRoute['name']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best review this file on https://github.com/nextcloud/server/pull/20114/files?w=1
90dda67
to
12c43b3
Compare
Rebased |
Lots of failures |
12c43b3
to
e07f126
Compare
d7058c6
to
8e786e4
Compare
8e786e4
to
4bae8db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP CS is not happy.
Some integration and acceptance tests failures are legit, and all seem to be caused by Unable to generate a URL for the named route \"cloud_federation_api.RequestHandler.addShare\" as such route does not exist.
Should be fixed by a last rebase as it's not caused by this PR. |
4bae8db
to
a0f75ae
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
ebba033
to
1b93d5f
Compare
SHould be good to go now? |
Lets do this and we fix stuff if it does boom |
The app-comments can be ignored, they are caused by a regression in the sidebar. The others are legit; for some reason with this pull request the Apps app and the Users app show a blank page (and in 8f650fe^ they work fine). |
which apps? |
aah the apps and user page |
Follow up to prevent #20038 from spreading