Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make remote checking more generic #20138

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Make remote checking more generic #20138

merged 4 commits into from
Apr 15, 2020

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen nickvergessen added this to the Nextcloud 19 milestone Mar 24, 2020
rullzer
rullzer approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test in dept but looks good.

This was referenced Apr 4, 2020
Merged
Merged
@rullzer
Copy link
Member

rullzer commented Apr 10, 2020

CI is not happy

@skjnldsv skjnldsv added 2. developing Work in progress 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Apr 11, 2020
@nickvergessen
Check all remotes for local access
5e402f8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Also disallow ; in remote urls
609b8af 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/make-remote-checking-more-generic branch from 936a5c2 to 4dc5b35 Compare April 14, 2020 16:56
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Apr 14, 2020
@nickvergessen
Fix unit tests
fd0c1a3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/make-remote-checking-more-generic branch from 4dc5b35 to fd0c1a3 Compare April 15, 2020 06:21
@nickvergessen
Allow local remotes in integration tests
4e846dd 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 5c0637b into master Apr 15, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/make-remote-checking-more-generic branch April 15, 2020 10:48
@icewind1991 icewind1991 mentioned this pull request Apr 17, 2020
Merged
@juliusknorr juliusknorr mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: federation
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @rullzer @georgehrke @skjnldsv