Unify default value for restricting user enumeration with settings #20139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the value was never enabled or disabled, the settings show "Restrict username enumeration to groups" as disabled. However, in some components it was enabled by default, which caused an inconsistency in the behaviour with respect to the settings, for example in the contacts menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nickvergessen
approved these changes
Mar 30, 2020
rullzer
deleted the
unify-default-value-for-restricting-user-enumeration-with-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #19569
If the value was never enabled or disabled, the settings show Restrict username enumeration to groups as disabled. However, in some components it was enabled by default, which caused an inconsistency in the behaviour with respect to the settings, for example in the contacts menu.
The acceptance tests for header were failing because of this. I have also added a new test to check the behaviour when username autocompletion is restricted to groups.