Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting tooltips for external storage config options #20276

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

icewind1991
Copy link
Member

allows explaining non-obvious config options a bit more

Would like to add a tooltip to the option from #19399

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 2, 2020
@icewind1991 icewind1991 added this to the Nextcloud 19 milestone Apr 2, 2020
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@rullzer
Copy link
Member

rullzer commented Apr 3, 2020

@rullzer rullzer added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 3, 2020
allows explaining non-obvious config options a bit more

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the files-external-param-tooltop branch from cb48e19 to 857957b Compare April 3, 2020 13:45
@icewind1991
Copy link
Member Author

fixed the files_external tests

@rullzer rullzer mentioned this pull request Apr 4, 2020
80 tasks
@rullzer rullzer merged commit 1d62b97 into master Apr 6, 2020
@rullzer rullzer deleted the files-external-param-tooltop branch April 6, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants