Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the return type of BeforeUserLoggedInEvent #20293

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Apr 3, 2020

the constructor receives the login name only

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added bug 3. to review Waiting for reviews labels Apr 3, 2020
@blizzz blizzz added this to the Nextcloud 19 milestone Apr 3, 2020
@blizzz blizzz requested review from rullzer and ChristophWurst April 3, 2020 16:03
@blizzz
Copy link
Member Author

blizzz commented Apr 3, 2020

/backport to stable18

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport?

@blizzz
Copy link
Member Author

blizzz commented Apr 3, 2020

backport?

according to the @SInCE info, the event is there as of NC 18.

@ChristophWurst
Copy link
Member

/backport to stable18

didn't see that before. I wanted to suggest this :)

@blizzz blizzz merged commit 2d0f29f into master Apr 3, 2020
@blizzz blizzz deleted the fix/noid/BeforeUserLoggedInEvent-returntype branch April 3, 2020 19:29
@backportbot-nextcloud
Copy link

backport to stable18 in #20296

@rullzer rullzer mentioned this pull request Apr 4, 2020
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants