Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icewind/smb to 3.2.3 #20363

Merged
merged 1 commit into from
Apr 9, 2020
Merged

update icewind/smb to 3.2.3 #20363

merged 1 commit into from
Apr 9, 2020

Conversation

icewind1991
Copy link
Member

Includes

  • proper exception for "network reset"
  • properly close the stream when an exception is thrown when trying to close
  • show the proper path in exception messages for stream close/write exceptions

Together with #20361 this makes sure part files are properly cleaned up if there is an exception (such as out of space)

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 8, 2020
@icewind1991 icewind1991 added this to the Nextcloud 19 milestone Apr 8, 2020
@icewind1991
Copy link
Member Author

/backport to stable18

@icewind1991
Copy link
Member Author

/backport to stable17

@skjnldsv skjnldsv merged commit 732a239 into master Apr 9, 2020
@skjnldsv skjnldsv deleted the smb-3.2.3 branch April 9, 2020 06:16
@backportbot-nextcloud
Copy link

The backport to stable18 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable17 failed. Please do this backport manually.

@rullzer rullzer mentioned this pull request Apr 9, 2020
80 tasks
@skjnldsv
Copy link
Member

/backport to stable18

@skjnldsv
Copy link
Member

/backport to stable17

@backportbot-nextcloud
Copy link

backport to stable18 in #20405 with conflicts ⚠️

@backportbot-nextcloud
Copy link

backport to stable17 in #20406 with conflicts ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants