Fix design and layout of notification mails

[jancborchardt]

• Fix notification mails height issue in Nextcloud Mail → @Bables55 @alexanderdd please test this because it fixes the issue you reported at Activity notification mail from Nextcloud is not displayed [$15] mail#599 :)
• Adjust vertical spacing
• Logo bar/box to circle so it stands nicely on its own
• Change font to native font stack

Also is a step towards simplifying the email template as per #9119

Just a question: How best to trigger the mails for testing? So far I did it inline in the browser.

Before

When reading notifications mails with the Mail app, you have to scroll down to see any content:

New

[szaimen]

@jancborchardt I think it looks much better then before but I would center-align the activity notification if there is only one. It would look then something like this:

[jancborchardt]

I would center-align the activity notification if there is only one. It would look then something like this:

Sure – but let’s do it in a follow-up, already touched this beast enough for now. :) There’s plenty of other stuff to fix as well still.

[ChristophWurst]

Test\Mail\EMailTemplateTest fails

[jancborchardt]

Test\Mail\EMailTemplateTest fails

So do I need to manually copy all the changes to:

• tests/data/emails/new-account-email.html
• tests/data/emails/new-account-email-custom.html
• tests/data/emails/new-account-email-single-button.html
• apps/settings/tests/Mailer/NewUserMailHelperTest.php

Or is there a simpler way?

[kesselb]

Logo needs a lot of space now. For me it's to much present. That email should be about the activity and not the instance logo.

[jancborchardt]

Logo needs a lot of space now. For me it's to much present. That email should be about the activity and not the instance logo.

I can reduce the padding a bit. Do you know something regarding my question on fixing the tests? :)

[kesselb]

master

this pr

The email settings test mail looks a bit broken.

[kesselb]

Do you know something regarding my question on fixing the tests? :)

The tests compare the generated html with the one saved at tests/data/emails/. You may update the expected output there.

[jancborchardt]

Ok, so as asked I need to just manually copy it over into these files?

• tests/data/emails/new-account-email.html
• tests/data/emails/new-account-email-custom.html
• tests/data/emails/new-account-email-single-button.html
• apps/settings/tests/Mailer/NewUserMailHelperTest.php

Or is there a simpler way?

---

As for the layout bug, I will remove that box-shadow – thanks for catching it!

[georgehrke]

As for the layout bug, I will remove that box-shadow – thanks for catching it!

Bump

[jancborchardt]

Rebased, removed the box-shadow, and fixed the tests. @georgehrke @kesselb @ChristophWurst

[jancborchardt]

The test sudo NOCOVERAGE=1 ./autotest.sh sqlite tests/lib/Mail/EMailTemplateTest.php passes locally, so I don’t understand why https://drone.nextcloud.com/nextcloud/server/28545/10/4 shows errors?

[kesselb]

@jancborchardt OCA\Settings\Tests\Mailer\NewUserMailHelperTest is the failing test. There is also some html markup to adjust.

[jancborchardt]

@jancborchardt OCA\Settings\Tests\Mailer\NewUserMailHelperTest is the failing test. There is also some html markup to adjust.

How can I run this test locally? Sorry for the stupid questions, but the documentation was not very clear or gave me commands that didn’t work, and it’s not very obvious how to run the tests. (Also I’m a designer, not dev. ;)

[kesselb]

Good question. I think the same command as for the other test should work.

The test is located here: apps/settings/tests/Mailer/NewUserMailHelperTest.php

[gary-kim]

Yeah, NOCOVERAGE=1 ./autotest.sh sqlite apps/settings/tests/Mailer/NewUserMailHelperTest.php will work.

[jancborchardt]

The test is located here: apps/settings/tests/Mailer/NewUserMailHelperTest.php

Aaah ok, didn’t know it was somewhere else. :) Thank you both @kesselb @gary-kim! :)

[jancborchardt]

Aaand all tests fixed now! :) That is, both of these:

• NOCOVERAGE=1 ./autotest.sh sqlite apps/settings/tests/Mailer/NewUserMailHelperTest.php
• NOCOVERAGE=1 ./autotest.sh sqlite tests/lib/Mail/EMailTemplateTest.php