Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use elseif instead of else if #20402

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Use elseif instead of else if #20402

merged 1 commit into from
Apr 10, 2020

Conversation

ChristophWurst
Copy link
Member

PSR2 requires braces around every control structure, so if you have

if ($a) {
  //
} else if ($b) {
  //
}

it will transform your code to

if ($a) {
  //
} else {
  if ($b) {
    //
  }
}

With elseifthe structure can remain unchanged.

@ChristophWurst
Use elseif instead of else if
14c996d 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 19 milestone Apr 10, 2020
@ChristophWurst ChristophWurst self-assigned this Apr 10, 2020
rullzer
rullzer approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 10, 2020
@skjnldsv skjnldsv merged commit 71b0738 into master Apr 10, 2020
@skjnldsv skjnldsv deleted the techdebt/elseif branch April 10, 2020 11:28
@rullzer rullzer mentioned this pull request Apr 13, 2020
Merged
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@gary-kim gary-kim gary-kim approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@xh3n1 xh3n1 Awaiting requested review from xh3n1

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @rullzer @skjnldsv @gary-kim