Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the translation catalog for "Share" #20439

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Apr 11, 2020

No description provided.

@Valdnet Valdnet added bug design Design, UI, UX, etc. feature: sharing labels Apr 11, 2020
@gary-kim gary-kim added the 3. to review Waiting for reviews label Apr 12, 2020
@gary-kim
Copy link
Member

/compile amend /

Change "files" to "files_sharing".

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@gary-kim
Copy link
Member

For next time, you have to add the sign-off to the commit message, not the GitHub description.

Probably a small enough change to forego a proper DCO. Any thoughts? @skjnldsv @rullzer

@skjnldsv
Copy link
Member

Probably a small enough change to forego a proper DCO. Any thoughts? @skjnldsv @rullzer

yes :)

@skjnldsv skjnldsv merged commit 8924214 into master Apr 12, 2020
@skjnldsv skjnldsv deleted the Valdnet-patch-3 branch April 12, 2020 07:08
@rullzer rullzer mentioned this pull request Apr 13, 2020
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants