Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that destination is not a directory. #20472

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Apr 14, 2020

Fix #19848

Otherwise file_put_contents will fail later.

@kesselb kesselb force-pushed the fix/19848/make-sure-destination-is-not-a-directory branch from ec87de3 to 2d61d9e Compare April 14, 2020 09:59
@kesselb kesselb added 3. to review Waiting for reviews bug labels Apr 14, 2020
@kesselb kesselb added this to the Nextcloud 19 milestone Apr 14, 2020
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

Otherwise file_put_contents will fail later.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the fix/19848/make-sure-destination-is-not-a-directory branch from 2d61d9e to 91ab811 Compare April 14, 2020 10:52
@rullzer rullzer merged commit d7a74d0 into master Apr 14, 2020
@rullzer rullzer deleted the fix/19848/make-sure-destination-is-not-a-directory branch April 14, 2020 13:20
@rullzer rullzer mentioned this pull request Apr 15, 2020
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[18.0.x] WebDAV MOVE: file_put_contents() is a directory
3 participants