Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sharing recommendation user display #20575

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fix Sharing recommendation user display #20575

merged 1 commit into from
Apr 22, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 21, 2020 •
edited
Loading

  • Fix deprecated uses
  • Fix avatar display
    Before After
    Capture d’écran_2020-04-21_09-39-16 Capture d’écran_2020-04-21_09-38-56

Found while digging on #20359

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: sharing feature: file sidebar Related to the file sidebar component labels Apr 21, 2020
@skjnldsv skjnldsv added this to the Nextcloud 19 milestone Apr 21, 2020
@skjnldsv skjnldsv self-assigned this Apr 21, 2020
@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv
Copy link
Member Author

/backport to stable18

@skjnldsv @npmbuildbot
Fix Sharing recommendation user display
7eceba7 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@rullzer rullzer mentioned this pull request Apr 21, 2020
Merged
55 tasks
MorrisJobke
MorrisJobke approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works 👍

@MorrisJobke MorrisJobke merged commit f0ad46d into master Apr 22, 2020
@MorrisJobke MorrisJobke deleted the fix/sharing-suggestions branch April 22, 2020 12:56
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 22, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #20596 with conflicts ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@schiessle schiessle Awaiting requested review from schiessle

@danxuliu danxuliu Awaiting requested review from danxuliu

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: file sidebar Related to the file sidebar component feature: sharing
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @MorrisJobke @juliusknorr