Make Cache::removeChildren non recursive #20724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
remove-children-non-recursive
branch
from
a256c52 to
d129bb0
Compare
Currently the "add new files during scanning" call stack is smaller than the "remove deleted files during scanning" call stack. This can lead to the scanner adding folders in the folder tree that are to deep to be removed. This changes the `removeChildren` logic to be non recursive so there is no limit to the depth of the folder tree during removal Signed-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobke
force-pushed
the
remove-children-non-recursive
branch
from
d129bb0 to
5af7d92
Compare
|
Rebased to get newer CI output and then this is ready for merge. |
MorrisJobke
added
4. to release
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
CI succeeded in the old commit. I just added one to accept the warning of Psalm for now. Because changing the reviewed code would introduce a new risk here. |
|
Psalm happy now -> merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "add new files during scanning" call stack is smaller than
the "remove deleted files during scanning" call stack. This can lead to
the scanner adding folders in the folder tree that are to deep to be
removed.
This changes the
removeChildrenlogic to be non recursive so there isno limit to the depth of the folder tree during removal
Signed-off-by: Robin Appelman robin@icewind.nl