Dispatch event on preview request #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @icewind1991 to be potential reviewers. |
| @@ -43,6 +43,8 @@ | |||
| */ | |||
| interface IPreview { | |||
|
|
|||
| const EVENT = self::class . ':' . 'PREVIEWREQUESTED'; | |||
There was a problem hiding this comment.
stop shouting, use CamelCase?
Fixes: #73 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
log_preview_access
branch
from
e50ef56
to
99ada40
Compare
Current coverage is 57.73% (diff: 61.11%)@@ master #2076 diff @@
==========================================
Files 1156 1156
Lines 69608 69622 +14
Methods 7018 7018
Messages 0 0
Branches 1200 1200
==========================================
+ Hits 40190 40199 +9
- Misses 29418 29423 +5
Partials 0 0
|
|
👍 |
|
@nickvergessen @icewind1991 Please review ;) |
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #73
@LukasReschke as discussed.