Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprectae OC.Util.formatDate and OC.Util.relativeModifiedDate #20988

Merged
merged 1 commit into from
May 18, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented May 15, 2020

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added this to the Nextcloud 20 milestone May 15, 2020
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label May 15, 2020
@ChristophWurst
Copy link
Member

ChristophWurst added the pending documentation label 11 seconds ago

Please add this for all of these deprecations and removals 🙏

And we should maybe also add this to #20953

@@ -114,6 +114,7 @@ export default {
* @returns {string} timestamp formatted as requested
*/
formatDate: function(timestamp, format) {
console.warn('OC.Util.formatDate is deprecated and will be removed in Nextcloud 21')
Copy link
Member

@juliusknorr juliusknorr May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise 👍

@rullzer
Copy link
Member Author

rullzer commented May 15, 2020

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the td/js/deprecate_util_moment_functions branch from bf4ce86 to 04d8873 Compare May 15, 2020 12:01
@rullzer rullzer force-pushed the td/js/deprecate_util_moment_functions branch 2 times, most recently from dfb9347 to bfc018b Compare May 15, 2020 17:37
@rullzer
Copy link
Member Author

rullzer commented May 15, 2020

/compile amend /

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the td/js/deprecate_util_moment_functions branch from bfc018b to d5a13f8 Compare May 15, 2020 17:47
@rullzer rullzer merged commit f73c1f7 into master May 18, 2020
@rullzer rullzer deleted the td/js/deprecate_util_moment_functions branch May 18, 2020 06:37
@ChristophWurst
Copy link
Member

Documented with the other changes from #20953

tintou pushed a commit to nextcloud/contacts that referenced this pull request Nov 15, 2020
tintou pushed a commit to nextcloud/contacts that referenced this pull request Nov 15, 2020
As per nextcloud/server#20988 OC.Util.relativeModifiedDate is deprecated.

Signed-off-by: Corentin Noël <corentin@elementary.io>
tintou pushed a commit to nextcloud/activity that referenced this pull request Nov 17, 2020
tintou pushed a commit to nextcloud/activity that referenced this pull request Nov 17, 2020
As per nextcloud/server#20988

Signed-off-by: Corentin Noël <corentin@elementary.io>
artonge pushed a commit to nextcloud/activity that referenced this pull request Jun 27, 2023
As per nextcloud/server#20988

Signed-off-by: Corentin Noël <corentin@elementary.io>
nextcloud-command pushed a commit to nextcloud/activity that referenced this pull request Jun 27, 2023
As per nextcloud/server#20988

Signed-off-by: Corentin Noël <corentin@elementary.io>
nextcloud-command pushed a commit to nextcloud/activity that referenced this pull request Jun 27, 2023
As per nextcloud/server#20988

Signed-off-by: Corentin Noël <corentin@elementary.io>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews javascript pending documentation This pull request needs an associated documentation update technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants