Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from database xml #21639

Merged
merged 6 commits into from
Jul 6, 2020
Merged

Move away from database xml #21639

merged 6 commits into from
Jul 6, 2020

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jun 30, 2020
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jun 30, 2020
@ChristophWurst
Copy link
Member

Time to add this to https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/upgrade-guide.html

@nickvergessen nickvergessen mentioned this pull request Jun 30, 2020
Merged
2 tasks
@nickvergessen
Copy link
Member Author

I'm confused, installing works locally. But I can see the issue drone it having.

@nickvergessen
Copy link
Member Author

F this part of our code… The sharing app has so many hacks....

@nickvergessen
Copy link
Member Author

So calling the tests individually any only the sharing tests NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh sqlite apps/files_sharing/tests/ works.
Seems like a previous test is clearing a list of registered mount providers or something somewhere and not restoring it properly.

The fun debugging begins 🐍

@MorrisJobke
Copy link
Member

What about removing the sharing app from this PR and get the remaining stuff in. Then debug the sharing stuff in a separate PR?

@nickvergessen
Copy link
Member Author

yeah well, fine by me, but it still blocks #21641 then

@nickvergessen nickvergessen mentioned this pull request Jul 6, 2020
Closed
@nickvergessen
Move federation to migrations
77c9ff8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Move federatedfilesharing to migrations
41d1d6d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Move files_external to migrations
347ab52 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Move files_trashbin to migrations
9001438 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Move user_ldap to migrations
556e23e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Update class loaders
57ccece 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/move-away-from-database-xml branch from 2457e87 to 57ccece Compare July 6, 2020 14:42
@nickvergessen
Copy link
Member Author

Moved to #21718

@MorrisJobke
Copy link
Member

Tested and works 👍

The failures are fixed in #21717

@MorrisJobke MorrisJobke merged commit 7ad0381 into master Jul 6, 2020
@MorrisJobke MorrisJobke deleted the techdebt/noid/move-away-from-database-xml branch July 6, 2020 20:42
@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 8, 2022 •
edited
Loading

Docs at https://docs.nextcloud.com//server/stable/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_21.html#last-version-with-database-xml-support-and-migration and https://docs.nextcloud.com//server/stable/developer_manual/basics/storage/migrations.html

@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Nov 8, 2022
@rullzer
Copy link
Member

rullzer commented Nov 8, 2022

Docs are right on time 👍

@nickvergessen
Copy link
Member Author

Just forgot to link them and was cleaning up my PRs witht he pending documentation label 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: install and update technical debt
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @ChristophWurst @MorrisJobke @rullzer