Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate files to the PSR container #21861

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Migrate files to the PSR container #21861

merged 2 commits into from
Aug 17, 2020

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jul 16, 2020 •
edited
Loading

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Jul 16, 2020
@ChristophWurst ChristophWurst self-assigned this Jul 16, 2020
@ChristophWurst ChristophWurst force-pushed the techdebt/files-psr-container branch from 1ba7586 to 8abd996 Compare July 16, 2020 13:50
@ChristophWurst
Copy link
Member Author

Files app still shows files 👍 🐨

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 16, 2020
@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Jul 16, 2020
@ChristophWurst ChristophWurst marked this pull request as ready for review July 16, 2020 13:51
@MorrisJobke MorrisJobke requested review from skjnldsv and kesselb July 20, 2020 14:40
@MorrisJobke
Copy link
Member

files integration tests fail.

@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
Merged
57 tasks
@ChristophWurst
Migrate files to the PSR container
07fcf14 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the techdebt/files-psr-container branch from 8abd996 to 07fcf14 Compare August 17, 2020 07:45
@faily-bot
Copy link

faily-bot bot commented Aug 17, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31848: failure

jsunit

Show full log 
PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (18.157 secs / 15.875 secs)

sqlite

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\UpdaterLegacyTest::testWrite
Failed asserting that 1597650786 is equal to 1597650787 or is greater than 1597650787.

/drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:118

acceptance-app-files

  • tests/acceptance/features/app-files.feature:22
  • tests/acceptance/features/app-files.feature:246
  • tests/acceptance/features/app-files.feature:262
  • tests/acceptance/features/app-files.feature:281
  • tests/acceptance/features/app-files.feature:289
Show full log 
  Scenario: open and close the details view again after coming back from a different section # /drone/src/tests/acceptance/features/app-files.feature:22
    Given I am logged in                                                                     # LoginPageContext::iAmLoggedIn()
    And I open the details view for "welcome.txt"                                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                  # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                                                             # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I open the "Recent" section                                                          # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "Recent"                                           # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I open the details view for "welcome.txt"                                            # FileListContext::iOpenTheDetailsViewFor()
      Row for file welcome.txt in file list could not be found after 100 seconds
      File actions menu button for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that the details view is open                                                  # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                                                             # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    When I open the "All files" section                                                      # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "All files"                                        # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I open the details view for "welcome.txt"                                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                  # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                                                             # FilesAppContext::iCloseTheDetailsView()
    Then I see that the details view is closed                                               # FilesAppContext::iSeeThatTheDetailsViewIsClosed()

  Scenario: marking a file as favorite causes the file list to be sorted again                            # /drone/src/tests/acceptance/features/app-files.feature:246
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    When I mark "welcome.txt" as favorite                                                                 # FileListContext::iMarkAsFavorite()
    Then I see that "welcome.txt" is marked as favorite                                                   # FileListContext::iSeeThatIsMarkedAsFavorite()
      Favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
      Favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

  Scenario: mark a file as favorite in the details view               # /drone/src/tests/acceptance/features/app-files.feature:281
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I open the details view for "welcome.txt"                     # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                           # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    When I mark the file as favorite in the details view              # FilesAppContext::iMarkTheFileAsFavoriteInTheDetailsView()
    Then I see that "welcome.txt" is marked as favorite               # FileListContext::iSeeThatIsMarkedAsFavorite()
      Favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that the file is marked as favorite in the details view # FilesAppContext::iSeeThatTheFileIsMarkedAsFavoriteInTheDetailsView()

  Scenario: unmark a file as favorite in the details view                 # /drone/src/tests/acceptance/features/app-files.feature:289
    Given I am logged in                                                  # LoginPageContext::iAmLoggedIn()
    And I open the details view for "welcome.txt"                         # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                               # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I mark the file as favorite in the details view                   # FilesAppContext::iMarkTheFileAsFavoriteInTheDetailsView()
    And I see that "welcome.txt" is marked as favorite                    # FileListContext::iSeeThatIsMarkedAsFavorite()
      Favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that the file is marked as favorite in the details view     # FilesAppContext::iSeeThatTheFileIsMarkedAsFavoriteInTheDetailsView()
    When I unmark the file as favorite in the details view                # FilesAppContext::iUnmarkTheFileAsFavoriteInTheDetailsView()
    Then I see that "welcome.txt" is not marked as favorite               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
    And I see that the file is not marked as favorite in the details view # FilesAppContext::iSeeThatTheFileIsNotMarkedAsFavoriteInTheDetailsView()

@MorrisJobke
Fix TagService DI name
f406f5d 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
MorrisJobke approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the name of the tag service and now also favoriting files works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 17, 2020
@MorrisJobke MorrisJobke merged commit 7b8adb1 into master Aug 17, 2020
@MorrisJobke MorrisJobke deleted the techdebt/files-psr-container branch August 17, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@julien-nc julien-nc Awaiting requested review from julien-nc

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @MorrisJobke @skjnldsv