-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix share transfer of single files and on the transfered node #22116
Conversation
1eb8ddc
to
2bbabfc
Compare
2bbabfc
to
e361e0c
Compare
CI says "no". |
d6974b3
to
25b9701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:+
Signed-off-by: Julius Härtl <jus@bitgrid.net>
e4f77ec
to
ac2999a
Compare
Ready for another review, since i needed to go a bit of a different way to check if a share is contained in the transferred directory. Tests seem to pass now (before the rebase). I'd actually like to extend the integration tests with some cases for this, but I'm still unable to get them to run locally, so I'd postpone this for a later point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Actually it seems to be a problem with reshares in general. Steps to reproduce:
Expected result:fileA is reshared from user3 to user2 Actual result:fileA is still reshared from user1 to user2 |
Ah, the source path is of course not null if no path is provided. 🙈 |
Fixes #21625
This fixes an issue where shares on single file transfers or on the root folder that is being transfered could not me moved over.
There were two issues here with the current implementation:
server/lib/private/Share20/Manager.php
Lines 302 to 305 in 43efac3
Steps to reproduce:
occ files:transfer-ownership --path=f100.txt admin user2