-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShareByMail: Migrate to GenerateSecurePasswordEvent #22162
Conversation
f04ecc2
to
34806db
Compare
oh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense!
The failing tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, tested and works 👍
But then they should also fail on the other DBs 🧐 Let's rerun them. |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31563: failuremariadb10.1-php7.2Show full log
acceptance-app-files
Show full log
|
Failure seems unrelated. Let me rebase and then we can merge this. |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
34806db
to
4dd5076
Compare
Was just the change to phpunit.xml which was already done in master -> merge |
Use GenerateSecurePasswordEvent for ShareByMail.
What a trip! I thought migrating to GenerateSecurePasswordEvent would be easy 🤣