Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShareByMail: Migrate to GenerateSecurePasswordEvent #22162

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 9, 2020

Use GenerateSecurePasswordEvent for ShareByMail.

What a trip! I thought migrating to GenerateSecurePasswordEvent would be easy 🤣

@kesselb kesselb force-pushed the enh/noid/password-generator-sharebymail branch 8 times, most recently from f04ecc2 to 34806db Compare August 9, 2020 23:32
@kesselb kesselb requested review from danxuliu and MorrisJobke August 9, 2020 23:33
@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Aug 9, 2020
@kesselb kesselb modified the milestones: Nextcloud 19.0.3, Nextcloud 20 Aug 9, 2020
@masayomitan
Copy link

oh

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense!

@splitt3r
Copy link
Contributor

The failing tests in mysql8.0-php7.2 look quite related. Shouldn't they be fixed here too? Or am i wrong?

@kesselb kesselb added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 10, 2020
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested and works 👍

@MorrisJobke
Copy link
Member

The failing tests in mysql8.0-php7.2 look quite related. Shouldn't they be fixed here too? Or am i wrong?

But then they should also fail on the other DBs 🧐 Let's rerun them.

@faily-bot
Copy link

faily-bot bot commented Aug 10, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31563: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #28 ('folder', 3, 5)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
      Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 10, 2020
@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
57 tasks
@MorrisJobke
Copy link
Member

Failure seems unrelated. Let me rebase and then we can merge this.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@MorrisJobke MorrisJobke force-pushed the enh/noid/password-generator-sharebymail branch from 34806db to 4dd5076 Compare August 11, 2020 19:58
@MorrisJobke
Copy link
Member

Was just the change to phpunit.xml which was already done in master -> merge

@MorrisJobke MorrisJobke merged commit 138f47a into master Aug 11, 2020
@MorrisJobke MorrisJobke deleted the enh/noid/password-generator-sharebymail branch August 11, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants