Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use user mount with matching shared storage only #22234

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Use user mount with matching shared storage only #22234

merged 1 commit into from
Sep 10, 2020

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 13, 2020 •
edited
Loading

This is the result of some extensive log statements, I could not yet reproduce the issue locally.

@juliusknorr juliusknorr force-pushed the bugfix/noid/reshare-mount branch from 4d3ddbf to abbab5c Compare August 13, 2020 12:08
@faily-bot

This comment has been minimized.

Sign in to view
@juliusknorr juliusknorr added 3. to review Waiting for reviews bug labels Aug 13, 2020
@juliusknorr
Use user mount with matching shared storage only
52eff4a 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/reshare-mount branch from abbab5c to 52eff4a Compare August 13, 2020 13:10
@juliusknorr juliusknorr marked this pull request as ready for review August 14, 2020 09:17
@juliusknorr
Copy link
Member Author

It is confirmed to fix the issue on the affected instance, but i could still not reproduce it anywhere

@MorrisJobke MorrisJobke added this to the Nextcloud 20 milestone Aug 14, 2020
@MorrisJobke
Copy link
Member

/backport to stable19

MorrisJobke
MorrisJobke approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke MorrisJobke requested a review from blizzz August 14, 2020 14:05
This was referenced Aug 21, 2020
Merged
Merged
@rullzer rullzer mentioned this pull request Sep 3, 2020
Merged
13 tasks
@juliusknorr
Copy link
Member Author

🏓 for reviews :)

@MorrisJobke
Copy link
Member

🏓 again

rullzer
rullzer approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.... 🐘

@MorrisJobke MorrisJobke merged commit e269f15 into master Sep 10, 2020
@MorrisJobke MorrisJobke deleted the bugfix/noid/reshare-mount branch September 10, 2020 14:19
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @MorrisJobke @rullzer