Add attributions for weather status in modal #22319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
design
julien-nc
force-pushed
the
enh/dashboard/attributions
branch
2 times, most recently
from
b1d854f to
077e139
Compare
|
I’d say let’s use "Weather service" as a heading, and there we could also put a checkbox saying "Enable weather" which by default is checked, but could be unchecked if people don’ŧ want weather at all. What do you think @eneiluj @juliushaertl? |
julien-nc
force-pushed
the
enh/dashboard/attributions
branch
from
077e139 to
d1b8c90
Compare
|
@jancborchardt Title changed, thanks. |
|
@jancborchardt @juliushaertl I was too lazy to create another branch+PR for this: the order of the statuses is now inverted (alphabetic sort by name for the moment). I started to make it possible to toggle weather status, i can get rid of it by removing it from the cheers |
|
Adjusted the design :) |
juliusknorr
reviewed
Aug 20, 2020
| @@ -59,6 +59,14 @@ | |||
|
|
|||
| <h3>{{ t('dashboard', 'Change background image') }}</h3> | |||
| <BackgroundSettings :background="background" @update:background="updateBackground" /> | |||
|
|
|||
| <h3>{{ t('dashboard', 'Weather service') }}</h3> | |||
There was a problem hiding this comment.
Ideally we should put this in the weather_status app somehow, but fine for now I'd say 👍
juliusknorr
approved these changes
Aug 20, 2020
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32137: failurejsunit
checkers
litmus
caldavtester-new-endpoint
caldavtester-old-endpoint
carddavtester-new-endpoint
carddavtester-old-endpoint
samba
sqlite-php7.3-webdav-apache
nodb
sqlite
mariadb10.1-php7.2
mariadb10.4-php7.3
mysql8.0-php7.2
mysql5.6-php7.2
postgres9-php7.3
postgres11-php7.2
integration-capabilities_features
integration-federation_features
integration-auth
integration-maintenance-mode
integration-ratelimiting
integration-carddav
integration-dav-v2
integration-ocs-v1
integration-checksums-v1
integration-external-storage
integration-provisioning-v1
integration-tags
integration-caldav
integration-comments
integration-comments-search
integration-favorites
integration-provisioning-v2
integration-webdav-related
integration-sharees-features
integration-sharees-v2-features
integration-sharing-v1
integration-sharing-v1-part2
integration-sharing-v1-part3
integration-sharing-v1-video-verification
integration-setup-features
integration-filesdrop-features
integration-transfer-ownership-features
integration-ldap-features
integration-ldap-openldap-features
integration-ldap-openldap-uid-features-php54-api
integration-ldap-openldap-uid-features
integration-ldap-openldap-numerical-id-features
integration-trashbin
integration-remote-api
integration-download
acceptance-access-levels
acceptance-app-files
acceptance-app-files-sharing
acceptance-app-files-sharing-link
acceptance-app-files-tags
acceptance-app-theming
acceptance-header
acceptance-login
acceptance-users
acceptance-apps
object-store-s3
object-store-azure
memcache-memcached
|
…tuses Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
enh/dashboard/attributions
branch
from
d927091 to
18057db
Compare
|
@jancborchardt @juliushaertl rebased and squashed. We can merge that if you want and do the "toggle weather" feature later. |
jancborchardt
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the header text and the attributions themselves 😁.