-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mount point to quota warning message #22913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/backport to stable19 |
/backport to stable18 |
rullzer
approved these changes
Sep 17, 2020
skjnldsv
approved these changes
Sep 17, 2020
/backport to stable20 |
makes it more clear to the user what the quota applies to Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
force-pushed
the
group-folder-quota-warning-mountpoint
branch
from
October 4, 2020 09:02
178981d
to
0dfdf3e
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 33635: failuresqliteShow full log
mariadb10.1-php7.3
mariadb10.4-php7.4
mysql8.0-php7.4
mysql5.6-php7.3
postgres9-php7.3Show full log
postgres11-php7.4
|
This was referenced Oct 4, 2020
Broken tests on master |
Fixed in #23193 |
@@ -545,6 +545,7 @@ public static function getStorageInfo($path, $rootInfo = null) { | |||
if ($owner) { | |||
$ownerDisplayName = $owner->getDisplayName(); | |||
} | |||
[,,,$mountPoint] = explode('/', $mount->getMountPoint(), 4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get the following error printed when running integration tests:
{"Exception":"Error","Message":"Undefined offset: 3 at \/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/legacy\/OC_Helper.php#548","Code":0,"Trace":[{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/legacy\/OC_Helper.php","line":548,"function":"onAll","class":"OC\\Log\\ErrorHandler","type":"::"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/apps\/provisioning_api\/lib\/Controller\/AUserData.php","line":190,"function":"getStorageInfo","class":"OC_Helper","type":"::"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/apps\/provisioning_api\/lib\/Controller\/AUserData.php","line":137,"function":"fillStorageInfo","class":"OCA\\Provisioning_API\\Controller\\AUserData","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/apps\/provisioning_api\/lib\/Controller\/UsersController.php","line":394,"function":"getUserData","class":"OCA\\Provisioning_API\\Controller\\AUserData","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":218,"function":"getUser","class":"OCA\\Provisioning_API\\Controller\\UsersController","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":127,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/AppFramework\/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/Route\/Router.php","line":308,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/ocs\/v1.php","line":88,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/ocs\/v2.php","line":24,"args":["\/home\/nickv\/Nextcloud\/21\/server\/ocs\/v1.php"],"function":"require_once"}],"File":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/Log\/ErrorHandler.php","Line":98,"CustomMessage":"--"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes it more clear to the user what the quota applies to
See also #22421