Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mount point to quota warning message #22913

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

icewind1991
Copy link
Member

makes it more clear to the user what the quota applies to

See also #22421

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 17, 2020
@icewind1991 icewind1991 added this to the Nextcloud 20 milestone Sep 17, 2020
@icewind1991
Copy link
Member Author

/backport to stable19

@icewind1991
Copy link
Member Author

/backport to stable18

@MorrisJobke MorrisJobke mentioned this pull request Sep 17, 2020
5 tasks
@MorrisJobke
Copy link
Member

/backport to stable20

@rullzer rullzer modified the milestones: Nextcloud 20, Nextcloud 21 Sep 18, 2020
makes it more clear to the user what the quota applies to

Signed-off-by: Robin Appelman <robin@icewind.nl>
@rullzer rullzer force-pushed the group-folder-quota-warning-mountpoint branch from 178981d to 0dfdf3e Compare October 4, 2020 09:02
@faily-bot
Copy link

faily-bot bot commented Oct 4, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33635: failure

sqlite

Show full log
There were 2 errors:

1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3

/drone/src/lib/private/legacy/OC_Helper.php:548
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:331
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:308

2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3

/drone/src/lib/private/legacy/OC_Helper.php:548
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:331
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:347

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mariadb10.1-php7.3

mariadb10.4-php7.4

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql8.0-php7.4

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql5.6-php7.3

postgres9-php7.3

Show full log
There were 2 errors:

1) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoUnlimited
Undefined offset: 3

/drone/src/lib/private/legacy/OC_Helper.php:548
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:331
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:308

2) OCA\DAV\Tests\Unit\Connector\Sabre\DirectoryTest::testGetQuotaInfoSpecific
Undefined offset: 3

/drone/src/lib/private/legacy/OC_Helper.php:548
/drone/src/apps/dav/lib/Connector/Sabre/Directory.php:331
/drone/src/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php:347

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

postgres11-php7.4

@skjnldsv
Copy link
Member

skjnldsv commented Oct 5, 2020

Broken tests on master ⚠️

@MorrisJobke
Copy link
Member

Broken tests on master ⚠️

Fixed in #23193

@@ -545,6 +545,7 @@ public static function getStorageInfo($path, $rootInfo = null) {
if ($owner) {
$ownerDisplayName = $owner->getDisplayName();
}
[,,,$mountPoint] = explode('/', $mount->getMountPoint(), 4);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get the following error printed when running integration tests:

{"Exception":"Error","Message":"Undefined offset: 3 at \/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/legacy\/OC_Helper.php#548","Code":0,"Trace":[{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/legacy\/OC_Helper.php","line":548,"function":"onAll","class":"OC\\Log\\ErrorHandler","type":"::"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/apps\/provisioning_api\/lib\/Controller\/AUserData.php","line":190,"function":"getStorageInfo","class":"OC_Helper","type":"::"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/apps\/provisioning_api\/lib\/Controller\/AUserData.php","line":137,"function":"fillStorageInfo","class":"OCA\\Provisioning_API\\Controller\\AUserData","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/apps\/provisioning_api\/lib\/Controller\/UsersController.php","line":394,"function":"getUserData","class":"OCA\\Provisioning_API\\Controller\\AUserData","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":218,"function":"getUser","class":"OCA\\Provisioning_API\\Controller\\UsersController","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":127,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/AppFramework\/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/Route\/Router.php","line":308,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/ocs\/v1.php","line":88,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/home\/nickv\/Nextcloud\/21\/server\/ocs\/v2.php","line":24,"args":["\/home\/nickv\/Nextcloud\/21\/server\/ocs\/v1.php"],"function":"require_once"}],"File":"\/home\/nickv\/Nextcloud\/21\/server\/lib\/private\/Log\/ErrorHandler.php","Line":98,"CustomMessage":"--"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants