Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve handling of files we can't access in the scanner #22943

Merged
merged 1 commit into from
Apr 5, 2023
Merged

improve handling of files we can't access in the scanner #22943

merged 1 commit into from
Apr 5, 2023

Conversation

icewind1991
Copy link
Member

instead of erroring, remove the items from the cache.

this situation can be triggered if a user has access to a file but looses it afterwards

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 18, 2020
@icewind1991 icewind1991 added this to the Nextcloud 21 milestone Sep 18, 2020
@icewind1991
Copy link
Member Author

/backport to stable20

@icewind1991
Copy link
Member Author

/backport to stable19

rullzer
rullzer approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 22, 2020
@rullzer
Copy link
Member

rullzer commented Oct 4, 2020

static code analysis is not happy: https://github.com/nextcloud/server/pull/22943/checks?check_run_id=1134675980

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Oct 6, 2020
This was referenced Dec 14, 2020
Merged
Merged
This was referenced Dec 28, 2020
Merged
Merged
@rullzer rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Jan 8, 2021
@kesselb kesselb mentioned this pull request Jan 8, 2021
Closed
@PVince81
Copy link
Member

@icewind1991 rebase and fix psalm ?

@icewind1991 icewind1991 force-pushed the scanner-no-access-handling branch from 6039742 to 7565b10 Compare March 24, 2021 16:05
@nextcloud nextcloud deleted a comment from faily-bot bot Mar 24, 2021
@icewind1991
Copy link
Member Author

rebasing made psalm happy

@icewind1991 icewind1991 added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Mar 24, 2021
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@blizzz
Copy link
Member

blizzz commented Jun 2, 2021

@icewind1991 could you check the tests?

@nextcloud nextcloud deleted a comment from blizzz Jun 7, 2021
@nextcloud nextcloud deleted a comment from blizzz Jun 7, 2021
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
@blizzz blizzz mentioned this pull request Jun 16, 2021
Merged
45 tasks
@blizzz
Copy link
Member

blizzz commented Jun 16, 2021

CI unhappy, 35 errors in samba tests

@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 24, 2021
@MorrisJobke MorrisJobke removed their request for review July 4, 2021 11:35
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv

This comment has been minimized.

Sign in to view
@nextcloud-command nextcloud-command force-pushed the scanner-no-access-handling branch from 7565b10 to 986a242 Compare October 13, 2021 10:23
@skjnldsv
Copy link
Member

Samba tests failing

@skjnldsv
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the scanner-no-access-handling branch from 986a242 to ebab4f8 Compare October 22, 2021 11:04
This was referenced Oct 25, 2021
Merged
Merged
@skjnldsv skjnldsv removed this from the Nextcloud 23 milestone Nov 1, 2021
max-nextcloud
max-nextcloud requested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix samba (tests)

@icewind1991 icewind1991 force-pushed the scanner-no-access-handling branch from ebab4f8 to 2364d1c Compare April 4, 2023 15:36
@icewind1991
improve handling of files we can't access in the scanner
b1f352c 
instead of erroring, remove the items from the cache.

this situation can be triggered if a user has access to a file but looses it afterwards

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the scanner-no-access-handling branch from 2364d1c to b1f352c Compare April 5, 2023 12:45
@icewind1991 icewind1991 merged commit 03e965a into master Apr 5, 2023
@icewind1991 icewind1991 deleted the scanner-no-access-handling branch April 5, 2023 19:36
This was referenced Apr 5, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud requested changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
2. developing Work in progress bug feature: external storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@icewind1991 @rullzer @PVince81 @MorrisJobke @blizzz @skjnldsv @juliusknorr @max-nextcloud