-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make share results distinguishable if there are more than one with the same display name #23017
Conversation
@jancborchardt Could you maybe give me some input here? Having the additional bottom line is not ideal as we usually have user status there now, though it is not yet implemented in the sharing autocomplete dialog. |
@juliushaertl Ah good point – how about putting it directly after the display name? Set as |
Yep, sounds good, any idea about if we should show the uid or email? quick summary:
|
I would tend towards email since we don’t really use the user id often, so it’s easier to identify people by mail. If it’s not unique, then they are also the same person? |
Yep indeed 😁 👍 |
ebfd85a
to
7d52b9a
Compare
Addressed the discussion and updated the first post with details about the implementation, ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fails.
3afa35c
to
d78d2d4
Compare
/compile / |
CI still fails |
b5d99c9
to
bcae605
Compare
conflicts :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great solution design-wise! :)
fa58ce7
to
3e7935c
Compare
Rebased and rebuilt. |
/backport to stable20 |
/backport to stable19 |
/backport to stable18 |
…e exact same display name Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3e7935c
to
8b13fd4
Compare
Resolved again |
The backport to stable20 failed. Please do this backport manually. |
The backport to stable19 failed. Please do this backport manually. |
The backport to stable18 failed. Please do this backport manually. |
@@ -150,6 +150,10 @@ export default class Share { | |||
|| this.#share.share_with | |||
} | |||
|
|||
get shareWithDisplayNameUnique() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tss tss tss @juliushaertl , no documentation? 😁 🙈
Keeping current behavior if display names are different
Same display name (first two users have an email set)
Share listing