Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move files_sharing from app.php to IBootstrap #24035

Closed
wants to merge 2 commits into from
Closed

Move files_sharing from app.php to IBootstrap #24035

wants to merge 2 commits into from

Conversation

MorrisJobke
Copy link
Member

No description provided.

@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Nov 10, 2020
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/files_sharing-ibootstrap branch from 76556d4 to 0233977 Compare November 10, 2020 20:16
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 11, 2020
@juliusknorr juliusknorr mentioned this pull request Nov 20, 2020
Merged
@nickvergessen
Copy link
Member

CI says nop nop nop

@rullzer rullzer mentioned this pull request Dec 14, 2020
Merged
59 tasks
@rullzer rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Dec 15, 2020
@MorrisJobke MorrisJobke mentioned this pull request Jan 22, 2021
Closed
@PVince81
Copy link
Member

please rebase and hope the Oracle will be kind

@MorrisJobke
Move files_sharing from app.php to IBootstrap
27d98c1 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Try to unregirster share backend after each test
1c4a9e5 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the techdebt/noid/files_sharing-ibootstrap branch from 9808cc4 to 1c4a9e5 Compare March 17, 2021 13:29
@skjnldsv
Copy link
Member

oracle said no

@MorrisJobke
Copy link
Member Author

oracle said no

All DBs say "no" ;)

This was referenced Mar 18, 2021
Merged
Merged
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 24, 2021 •
edited
Loading

Maybe also look into b156cf8 (from #21641)

This was referenced May 20, 2021
Merged
Merged
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 Jun 2, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@MorrisJobke
Copy link
Member Author

Seems to be worked on in #28314 - let me close this one then.

@MorrisJobke MorrisJobke deleted the techdebt/noid/files_sharing-ibootstrap branch October 16, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
2. developing Work in progress technical debt
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
6 participants
@MorrisJobke @nickvergessen @PVince81 @skjnldsv @ChristophWurst @rullzer