Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Change to the name of the app #24571

Merged
merged 1 commit into from
Dec 30, 2020
Merged

l10n: Change to the name of the app #24571

merged 1 commit into from
Dec 30, 2020

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Dec 5, 2020

It should refer to the application name "Files".

@faily-bot
Copy link

faily-bot bot commented Dec 5, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 225: failure

mysql8.0-php7.4

Show full log
There was 1 error:

1) OCA\DAV\Tests\unit\Connector\Sabre\RequestTest\EncryptionMasterKeyUploadTest::testChunkedUpload
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 814

/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:814
/drone/src/apps/dav/lib/HookManager.php:157
/drone/src/apps/dav/lib/AppInfo/Application.php:131
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:264
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:239
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:73
/drone/src/lib/private/EventDispatcher/SymfonyAdapter.php:85
/drone/src/lib/private/User/Session.php:569
/drone/src/lib/private/User/Session.php:415
/drone/src/lib/private/User/Session.php:624
/drone/src/lib/private/User/Session.php:367
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/Auth.php:84
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:192
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:144
/drone/src/3rdparty/sabre/event/lib/WildcardEmitterTrait.php:89
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:458
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:251
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:319
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:134
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:116
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/UploadTest.php:101

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testDeleteSingleShare
Failed asserting that an array is empty.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:486

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@rullzer rullzer added this to the Nextcloud 21 milestone Dec 28, 2020
@rullzer
Copy link
Member

rullzer commented Dec 28, 2020

/compile amend /

1 similar comment
@rullzer
Copy link
Member

rullzer commented Dec 29, 2020

/compile amend /

@rullzer rullzer mentioned this pull request Dec 30, 2020
39 tasks
@rullzer
Copy link
Member

rullzer commented Dec 30, 2020

/compile amend /

@rullzer
Copy link
Member

rullzer commented Dec 30, 2020

/compile amend /

It should refer to the application name "Files".

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@rullzer rullzer merged commit 36281c6 into master Dec 30, 2020
@rullzer rullzer deleted the Valdnet-patch-4 branch December 30, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants