Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #24682]: ensure federation cloud id is retruned if FN property not found #24683

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

doc75
Copy link
Contributor

@doc75 doc75 commented Dec 13, 2020

This PR is fixing #24682

I have tested it on my migrated instance (19.0.6) and it is working fine.

Let me know if anything is missing or need to be reworked (I am not an expert)

…roperty not found

Signed-off-by: Guillaume Virlet <github@virlet.org>
@kesselb kesselb added 3. to review Waiting for reviews bug labels Dec 14, 2020
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@rullzer
Copy link
Member

rullzer commented Dec 15, 2020

/backport to stable20

@rullzer
Copy link
Member

rullzer commented Dec 15, 2020

/backport to stable19

@rullzer rullzer added this to the Nextcloud 21 milestone Dec 15, 2020
@rullzer rullzer mentioned this pull request Dec 15, 2020
59 tasks
@juliusknorr juliusknorr merged commit d37034f into nextcloud:master Dec 15, 2020
@welcome
Copy link

welcome bot commented Dec 15, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@blizzz
Copy link
Member

blizzz commented Dec 15, 2020

Nice catch!

yeah. i thought this is a required field.

@rullzer
Copy link
Member

rullzer commented Jan 5, 2021

/backport to stable20

@rullzer
Copy link
Member

rullzer commented Jan 5, 2021

/backport to stable19

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@rullzer
Copy link
Member

rullzer commented Jan 5, 2021

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

blizzz referenced this pull request Jan 5, 2021
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants