Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] LDAP: fix inGroup for memberUid type of group memberships #24716

Merged
merged 6 commits into from
Jan 7, 2021
Merged

[stable20] LDAP: fix inGroup for memberUid type of group memberships #24716

merged 6 commits into from
Jan 7, 2021

Commits on Dec 15, 2020

  1. flatten result array as expected by following code 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz @backportbot
    blizzz authored and backportbot[bot] committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    d818975 View commit details
    Browse the repository at this point in the history

  2. moved the array_reduce to fix large search case 

    also added some additional comments and renamed some vars to make it intuitive whats in them

Signed-off-by: Tobias Perschon <tobias@perschon.at>
    @tofuSCHNITZEL @backportbot
    tofuSCHNITZEL authored and backportbot[bot] committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    250c753 View commit details
    Browse the repository at this point in the history

  3. use faster and less hungry foreach 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz @backportbot
    blizzz authored and backportbot[bot] committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    213464a View commit details
    Browse the repository at this point in the history

  4. check number of members after potential resolving of rdns 

    - the type check is not necessary anymore for the return type of
  _groupMembers()

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz @backportbot
    blizzz authored and backportbot[bot] committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    cca1fb7 View commit details
    Browse the repository at this point in the history

  5. add unit tests 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz @backportbot
    blizzz authored and backportbot[bot] committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    43c6bc1 View commit details
    Browse the repository at this point in the history

  6. php-cs happyness 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz @backportbot
    blizzz authored and backportbot[bot] committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    270eb6c View commit details
    Browse the repository at this point in the history