Cancel user search requests to avoid duplicate results being added #24721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
added
bug
3. to review
juliusknorr
requested review from
rullzer,
ChristophWurst,
blizzz and
skjnldsv
ChristophWurst
approved these changes
Dec 16, 2020
skjnldsv
approved these changes
Dec 16, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/user-search-cancel
branch
from
c41f324
to
d8a1685
Compare
skjnldsv
added
4. to release
|
This will go before #24721 |
Will it?
|
|
/backport to stable20 |
I had an automerge enabled on this one ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues where users where added multiple times when typing into the search due to slow requests still pending when the new search request for the updated query was issued.