Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dompurify from 2.2.3 to 2.2.6 #24772

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 19, 2020

Bumps dompurify from 2.2.3 to 2.2.6.

Release notes

Sourced from dompurify's releases.

DOMPurify 2.2.6

  • Added new mXSS prevention logic created by SecurityMB

DOMPurify 2.2.4

  • Fixed a new MathML-based bypass submitted by PewGrand
  • Fixed a new SVG-related bypass submitted by SecurityMB
  • Updated NodeJS CI to Node 14.x and Node 15.x
  • Cleaned up _forceRemove logic for better reliability
Commits
  • b11cb72 chore: Preparing 2.2.6 release after failed 2.2.5 attempt /2
  • 395cc83 chore: Preparing 2.2.6 release after failed 2.2.5 attempt
  • 8a1c887 chore: Preparing 2.2.5 release
  • 77e740e Merge pull request #496 from securityMB/main
  • 9dd47cb Create a polyfill for lookupGetter to make IE10 happy
  • 8e29990 fix: Made use of proper helper method to get parentNode
  • 7e3a705 fix: Fixed an issue with parent node mapping in MSIE11
  • d1cf8c6 test: Fixed additional Edge 17 and MSIE11 tests
  • 1446372 test: Fixed a bunch of Edge 17 and MSIE11 tests
  • 7d9bc6a fix: Removed usage of has()
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @juliushaertl.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Copy link
Member

@nextcloud-bot nextcloud-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@rullzer rullzer mentioned this pull request Dec 21, 2020
39 tasks
@rullzer
Copy link
Member

rullzer commented Dec 21, 2020

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the dependabot/npm_and_yarn/dompurify-2.2.6 branch from 54116e1 to f0b6d51 Compare December 21, 2020 08:16
@rullzer
Copy link
Member

rullzer commented Dec 21, 2020

/compile amend /

@skjnldsv
Copy link
Member

jsunit

PhantomJS 2.1.1 (Linux 0.0.0) ERROR
1028 | {
1029 | "message": "TypeError: null is not a function (evaluating 'ne(e)')\nat core/js/dist/main.js:1:1286134",
1030 | "str": "TypeError: null is not a function (evaluating 'ne(e)')\nat core/js/dist/main.j
s:1:1286134"
1031 | }
1032


@rullzer rullzer mentioned this pull request Dec 28, 2020
39 tasks
@rullzer
Copy link
Member

rullzer commented Dec 28, 2020

@dependabot-bot recreate

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/dompurify-2.2.6 branch from f0b6d51 to 4ce1c0b Compare December 28, 2020 09:52
Copy link
Member

@nextcloud-bot nextcloud-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@rullzer
Copy link
Member

rullzer commented Dec 28, 2020

/compile amend /

@juliusknorr

This comment has been minimized.

@juliusknorr
Copy link
Member

Turns out the issue is PhantomJS having issues with https://github.com/cure53/DOMPurify/blob/aa612d0e1b3ed0962003186bc35fb4bc0dcf227e/src/purify.js#L109-L114

#24872 is an attempt to move the jsunit tests to a more modern runner.

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.2.3 to 2.2.6.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@2.2.3...2.2.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@juliusknorr juliusknorr force-pushed the dependabot/npm_and_yarn/dompurify-2.2.6 branch from 8c7b441 to 594c8fc Compare December 29, 2020 10:14
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 29, 2020
@dependabot-preview dependabot-preview bot merged commit f25826a into master Dec 29, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/dompurify-2.2.6 branch December 29, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: dependencies javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants