Add migration for oc_share_external columns #24829

PVince81 · 2020-12-23T14:14:49Z

TEST: regular install
TEST: migrate from NC 21.0.0beta2
TEST: migrate from v20.0.4
TEST: on my own server

Partial fix for #24813

PVince81 · 2020-12-23T14:19:18Z

yeah, so I had this locally as well and double checked everything, class name, file name, etc.
but have no clue what's wrong...

Migration step 'OCA\Files_Sharing\Migration\Version21000Date20201223143245' is unknown

PVince81 · 2020-12-23T14:40:23Z

BUG: can't drop assignable without also dropping/recreating the index => discarded the change

Add column "parent" if missing. Drop column "lastscan" if exists. Signed-off-by: Vincent Petry <vincent@nextcloud.com>

PVince81 · 2020-12-23T14:45:53Z

I decided to discard the change about the assignable column for now. Solving it will need more gymnastics as it will need to adjust the index (possibly in the occ command) and only then we can drop the column.

PVince81 · 2020-12-23T15:15:29Z

ouch, I redid a diff and:

share_type is missing too

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

faily-bot · 2020-12-23T15:59:20Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 687: failure

mysql5.6-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testWriteStream
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
-Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
-Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
-Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'
+''

/drone/src/tests/lib/Files/Storage/Storage.php:661

acceptance-users

tests/acceptance/features/users.feature:47

Show full log

  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

PVince81 · 2020-12-23T16:17:00Z

Unrelated fails (added here #22305 (comment))

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

the failing acceptance test also seems unrelated:

  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)

rullzer

🐘

juliusknorr

Tested and works 👍

juliusknorr · 2021-01-05T08:34:18Z

/backport stable20

juliusknorr · 2021-01-05T08:34:30Z

/backport to stable20

PVince81 added the 2. developing Work in progress label Dec 23, 2020

PVince81 added this to the Nextcloud 21 milestone Dec 23, 2020

PVince81 self-assigned this Dec 23, 2020

PVince81 added the bug label Dec 23, 2020

PVince81 force-pushed the bugfix/24813/add-missing-migrations branch from 7ee3529 to 8505d7b Compare December 23, 2020 14:31

Adjust share_external table

07bf663

Add column "parent" if missing. Drop column "lastscan" if exists. Signed-off-by: Vincent Petry <vincent@nextcloud.com>

PVince81 force-pushed the bugfix/24813/add-missing-migrations branch from 8505d7b to 07bf663 Compare December 23, 2020 14:44

PVince81 changed the title ~~Bugfix/24813/add missing migrations~~ Add migration for oc_share_external columns Dec 23, 2020

PVince81 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 23, 2020

PVince81 requested review from juliusknorr and rullzer December 23, 2020 14:47

PVince81 marked this pull request as ready for review December 23, 2020 14:49

PVince81 mentioned this pull request Dec 23, 2020

Missing columns after OC 10.5 -> NC 21.0.0beta2 upgrade #24813

Closed

1 task

Also add missing oc_share_external.share_type column

6c0de14

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

PVince81 force-pushed the bugfix/24813/add-missing-migrations branch from 4b57c47 to 6c0de14 Compare December 23, 2020 15:20

PVince81 mentioned this pull request Dec 23, 2020

Look into unstable tests #22305

Closed

This was referenced Dec 23, 2020

21 beta3 #24765

Merged

21 beta4 #24852

Merged

rullzer approved these changes Dec 28, 2020

View reviewed changes

rullzer mentioned this pull request Jan 4, 2021

21 beta5 #24951

Merged

5 tasks

juliusknorr approved these changes Jan 5, 2021

View reviewed changes

juliusknorr merged commit 39c67d9 into master Jan 5, 2021

juliusknorr deleted the bugfix/24813/add-missing-migrations branch January 5, 2021 08:32

backportbot-nextcloud bot added the backport-request label Jan 5, 2021

backportbot-nextcloud bot mentioned this pull request Jan 5, 2021

[stable20] Add migration for oc_share_external columns #24963

Merged

backportbot-nextcloud bot removed the backport-request label Jan 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add migration for oc_share_external columns #24829

Add migration for oc_share_external columns #24829

PVince81 commented Dec 23, 2020 •

edited

Loading

PVince81 commented Dec 23, 2020

PVince81 commented Dec 23, 2020 •

edited

Loading

PVince81 commented Dec 23, 2020

PVince81 commented Dec 23, 2020 •

edited

Loading

faily-bot bot commented Dec 23, 2020

PVince81 commented Dec 23, 2020 •

edited

Loading

rullzer left a comment

juliusknorr left a comment

juliusknorr commented Jan 5, 2021

juliusknorr commented Jan 5, 2021

Add migration for oc_share_external columns #24829

Add migration for oc_share_external columns #24829

Conversation

PVince81 commented Dec 23, 2020 • edited Loading

PVince81 commented Dec 23, 2020

PVince81 commented Dec 23, 2020 • edited Loading

PVince81 commented Dec 23, 2020

PVince81 commented Dec 23, 2020 • edited Loading

faily-bot bot commented Dec 23, 2020

Status of 687: failure

mysql5.6-php7.3

acceptance-users

PVince81 commented Dec 23, 2020 • edited Loading

rullzer left a comment

Choose a reason for hiding this comment

juliusknorr left a comment

Choose a reason for hiding this comment

juliusknorr commented Jan 5, 2021

juliusknorr commented Jan 5, 2021

PVince81 commented Dec 23, 2020 •

edited

Loading

PVince81 commented Dec 23, 2020 •

edited

Loading

PVince81 commented Dec 23, 2020 •

edited

Loading

PVince81 commented Dec 23, 2020 •

edited

Loading