Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all the things for Guzzle 7 (php8 compat) #24917

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Update all the things for Guzzle 7 (php8 compat) #24917

merged 1 commit into from
Jan 5, 2021

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 30, 2020 •
edited
Loading

Guzzle 6 doesn't support php8, hence we need this for 21 for full php8
support.

@ChristophWurst ChristophWurst added this to the Nextcloud 21 milestone Dec 30, 2020
@ChristophWurst ChristophWurst self-assigned this Dec 30, 2020
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update and removed 2. developing Work in progress labels Dec 30, 2020
@rullzer rullzer mentioned this pull request Jan 4, 2021
Merged
5 tasks
rullzer
rullzer approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 🚬 test was not blowing up
Lets do this

@ChristophWurst
Update all the things for Guzzle 7 (php8 compat)
9b833f5 
Guzzle 6 doesn't support php8, hence we need this for 21 for full php8
support.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst marked this pull request as ready for review January 5, 2021 12:32
@juliusknorr juliusknorr merged commit 15b8bb9 into master Jan 5, 2021
@juliusknorr juliusknorr deleted the enhancement/guzzle7 branch January 5, 2021 15:44
@ChristophWurst ChristophWurst mentioned this pull request Nov 14, 2022
Merged
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer rullzer approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@blizzz blizzz Awaiting requested review from blizzz

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@splitt3r splitt3r Awaiting requested review from splitt3r

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews feature: dependencies
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @rullzer @juliusknorr