Replace patchwork/utf8 with symfony-polyfill-* #25015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
approved these changes
Jan 7, 2021
MorrisJobke
approved these changes
Jan 7, 2021
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
MorrisJobke
force-pushed
the
fix/no-double-intl-polyfill
branch
from
54afdee to
287c26b
Compare
MorrisJobke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test
ìntlextensionoccOn master: 💥 because the polyfill redeclares a function
Here: inner piece
Full disclaimer: I don't fully know if everything is working as before as it's hard to tell where the polyfill is active or not and if they behave the exact same way. But at least we use a more widely used package instead of the old, pratically unmaintained one.