Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print an exception trace for setup exceptions #25021

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Print an exception trace for setup exceptions #25021

merged 2 commits into from
Jan 8, 2021

Conversation

ChristophWurst
Copy link
Member

Doing this because in nextcloud/mail#4319 I received

Bildschirmfoto von 2021-01-07 20-12-34

Right now any setup error will just result in the exception message
being printed. In some cases this doesn't give any insights into what
went wrong. This adds some dedicated logic to print the exception trace
and any previous exceptions to the CLI.

@ChristophWurst
Print an exception trace for setup exceptions
f192136 
Right now any setup error will just result in the exception message
being printed. In some cases this doesn't give any insights into what
went wrong. This adds some dedicated logic to print the exception trace
and any previous exceptions to the CLI.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Jan 7, 2021
@ChristophWurst ChristophWurst added this to the Nextcloud 21 milestone Jan 7, 2021
@ChristophWurst ChristophWurst self-assigned this Jan 7, 2021
@ChristophWurst
Copy link
Member Author

Now I see this 🙏
Bildschirmfoto von 2021-01-07 20-19-07

rullzer
rullzer approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@MorrisJobke
Add more previous exceptions to database setup code
d0ac76a 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
MorrisJobke approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

I ran into this today as well and now it shows the exception plus the previous one instead of "username/password wrong" while it was a connection issue:

Bildschirmfoto 2021-01-07 um 21 03 42

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 7, 2021
@rullzer rullzer merged commit 645e3e6 into master Jan 8, 2021
@rullzer rullzer deleted the enhancement/occ-install-exception-trace branch January 8, 2021 07:22
@rullzer rullzer mentioned this pull request Jan 8, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: install and update
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @rullzer @MorrisJobke