-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable20] dont offer to edit external config settings if we can't edit them #25132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloud
bot
requested review from
icewind1991,
juliusknorr,
MorrisJobke and
rullzer
January 14, 2021 16:33
MorrisJobke
reviewed
Jan 15, 2021
Merged
MorrisJobke
requested changes
Jan 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Let's wait for 20.0.7 to be out
MorrisJobke
approved these changes
Jan 19, 2021
Merged
rullzer
approved these changes
Jan 28, 2021
rullzer
requested changes
Jan 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI says no...
@icewind1991 please check
Merged
Merged
Co-authored-by: Morris Jobke <hey@morrisjobke.de> Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
backport/24661/stable20
branch
from
February 18, 2021 14:56
1b36875
to
e7805e5
Compare
CI is happy |
rullzer
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #24661