-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for webp #25173
Merged
Merged
Add support for webp #25173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
MorrisJobke,
ChristophWurst,
juliusknorr and
skjnldsv
January 17, 2021 20:11
MorrisJobke
approved these changes
Jan 18, 2021
juliusknorr
approved these changes
Jan 18, 2021
Psalm is not happy:
|
ChristophWurst
requested changes
Jan 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be great if you actually added the webp class to git :)
mimimi |
ChristophWurst
approved these changes
Jan 18, 2021
Including handling in OC_Image But also a preview provider Of course only works if your php actually supports webp Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
enh/webp_support
branch
from
January 19, 2021 19:17
afbf961
to
6d4afca
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1494: failureacceptance-users
Show full log
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including handling in OC_Image
But also a preview provider
Of course only works if your php actually supports webp
Most useful feature of the release as it allow sharing webp memes and getting a proper preview for it.