Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd element ID after component mount. #25182

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

nickvergessen
Copy link
Member

Me:

I think I just found out why Notifications bell is always missing after hybernate.
document.getElementById('unified-search') returns null after initial mount. and aparently the id from

<HeaderMenu id="unified-search"
is not being set on the element.
I guess because HeaderMenu has an id prop and is not setting it itself anymore:
id: {
type: String,
required: true,
},

Can I just fix it in HeaderMenu by id="id"

@skjnldsv

of course :)

While now I think it's not fixing it, we should still make sure the id from

<div id="unified-search"></div>
should remain

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/readd-element-id branch from edd5e6e to 18fdefe Compare January 18, 2021 12:53
@skjnldsv skjnldsv merged commit 0ddcf0a into master Jan 18, 2021
@skjnldsv skjnldsv deleted the bugfix/noid/readd-element-id branch January 18, 2021 20:08
@rullzer rullzer mentioned this pull request Jan 19, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants