-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump phpseclib/phpseclib from 2.0.25 to 2.0.30 #25214
Bump phpseclib/phpseclib from 2.0.25 to 2.0.30 #25214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
e82e6fa
to
15aab23
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
15aab23
to
4373afe
Compare
Ok got it. So the new phpseclib fails on parsing the root.crt since it contains more than 1 cert. We still ahve to fix:
|
So we have to split it manually and do it ourselves Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* @return string[] | ||
*/ | ||
private function splitCerts(string $cert): array { | ||
preg_match_all('([\-]{3,}[\S\ ]+?[\-]{3,}[\S\s]+?[\-]{3,}[\S\ ]+?[\-]{3,})', $cert, $matches); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luckily we have tests that confirm this 🙈
I think drone got stuck |
yeah restarted it so lets see |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1555: failureacceptance-app-files-sharing-link
Show full log
|
So now different tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
nextcloud/3rdparty#592