Drop authtoken_version_index

[rullzer]

The index was used when deleting old tokens. On top of that the index is
of course not that great since the version is either 1 or 2.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

[MorrisJobke]

Could you describe the problem here in a bit more detail?

[rullzer]

Could you describe the problem here in a bit more detail?

It was a cold winter night. The wind was howling around the house. It was a night as you know from the movies right before something terrible happens. It was a night like this I was going over a slow query log. Here I noticed that there were several long running queries looking like:

DELETE FROM `oc_authtoken` 
WHERE (`last_activity` < 1609316716)
AND (`type` = 0) 
AND (`remember` = 1) 
AND (`version` = 2);

I should have known better. But again as in the movies I walked right into the darkness of the database. And I ran an EXPLAIN on this query. Which showed me there were two indexies on this table that could be used: authtoken_last_activity_idx or authtoken_version_index. Then when I looked at the index used breath stopped. Everything went cold. I saw it was using the authtoken_version_index. Which only has a cardinality of 3. Thus resulting in analyzing >80k rows for the final query. But I was determined to kill this monster! I summoned the magic of the dropIndex and made the database respect my wishes! The authtoken_version_index is gone! And the queries on the oc_authtoken table run at much higher speeds again!

[MorrisJobke]

Now there is only the one that is triggered by deleteByName https://github.com/nextcloud/server/blob/master/lib/private/Authentication/Token/DefaultTokenMapper.php#L168-L170

This one is usually called by the delete client API for OAuth2 and thus not that often like the one you mentioned above.

[MorrisJobke]

Let me squash and then this looks good 👍

[rullzer]

Now there is only the one that is triggered by deleteByName https://github.com/nextcloud/server/blob/master/lib/private/Authentication/Token/DefaultTokenMapper.php#L168-L170

This one is usually called by the delete client API for OAuth2 and thus not that often like the one you mentioned above.

Yeah but for that a new index on name would probably make sense.