Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable21] Make user list pagination more tolerant #25476

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 4, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #25443

In case the server returns more results than expected by the limit, it
is now still interpreted as there being more results to query.

This situation can happen when there are multiple user backends in
place.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the backport/25443/stable21 branch from d62639b to a1e7ac9 Compare February 4, 2021 09:16
@PVince81
Copy link
Member

PVince81 commented Feb 4, 2021

I've recompiled the assets and squashed.
Retested the users list with a lot of users, pagination looked fine.

@rullzer rullzer mentioned this pull request Feb 5, 2021
2 tasks
@PVince81
Copy link
Member

PVince81 commented Feb 5, 2021

not sure why the php 7.2 linter is stuck waiting. this is anyway just JS changes.

second reviewer ?

@PVince81
Copy link
Member

PVince81 commented Feb 5, 2021

who can force merge ?

@rullzer rullzer merged commit ba63f58 into stable21 Feb 5, 2021
@rullzer rullzer deleted the backport/25443/stable21 branch February 5, 2021 10:04
@rullzer rullzer mentioned this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants