-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type the experssionbuilders #25656
Type the experssionbuilders #25656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😻
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/OCIExpressionBuilder.php
Outdated
Show resolved
Hide resolved
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 2405: failuresqliteShow full log
mariadb10.1-php7.3Show full log
mariadb10.4-php7.4Show full log
mysql8.0-php7.4Show full log
postgres9.6-php7.3Show full log
postgres11-php7.4Show full log
postgres12-php7.4Show full log
postgres13-php7.4Show full log
|
9f753e2
to
de56159
Compare
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
lib/private/DB/QueryBuilder/ExpressionBuilder/OCIExpressionBuilder.php
Outdated
Show resolved
Hide resolved
Resolved @nickvergessen |
Time to squash and fixup? |
22f3b30
to
4bdf9f5
Compare
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* @since 9.0.0 | ||
* | ||
* @psalm-taint-sink sql $column | ||
* @psalm-taint-sink sql $type | ||
*/ | ||
public function castColumn($column, $type); | ||
public function castColumn(string $column, $type): IQueryFunction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So before this allowed to also cast "expressions" (like functions).
It was used e.g. in the user_usage_report
app:
nextcloud/user_usage_report#69 (comment)
Before:
UPDATE `oc_preferences` SET `configvalue` = (`configvalue` + 1) WHERE (`userid` = :user) AND (`configkey` = :action) AND (`appid` = :appid)
After:
UPDATE `oc_preferences` SET `configvalue` = `(`configvalue` + 1)` WHERE (`userid` = :user) AND (`configkey` = :action) AND (`appid` = :appid)
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl