apply object store copy optimization when 'cross storage' copy is wit…

[icewind1991]

…hin the same object store

This applies to copying from/to groupfolders, shares, etc.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2441: failure

acceptance-users

• tests/acceptance/features/users.feature:47

Show full log

  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

[PVince81]

🐘

[rullzer]

psalm is not happy and neither is the php-cs checker ;)

[icewind1991]

made cs and psalm happy and squashed

[PVince81]

restarted failed build

[icewind1991]

/backport to stable21

[icewind1991]

/backport to stable20

[icewind1991]

/backport to stable19