Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include RichObject for forms #25758

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Feb 22, 2021

Includes the form-richObject for Events/Activities. Ref. nextcloud/forms#789

@nickvergessen I'm not completely sure, what to set as since. I now set 21.0.1 as this seems to me like the 'next' release. However, this PR is now on master (so 22.0.0?), Forms still supports 19, so 19.0.10 with a backport? 🙈

@jotoeri jotoeri added the 3. to review Waiting for reviews label Feb 22, 2021
@nickvergessen
Copy link
Member

Well this is "public api", it mostly means 22, we so far never backported stuff on it. But then again new things don't break old consumers of the API so should be okay to backport.

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving apart of the since version which we have to clarify

@nickvergessen
Copy link
Member

So we also have 11.0.2 on "call" so I guess we can backport this as well.

@jotoeri
Copy link
Member Author

jotoeri commented Feb 22, 2021

So i set this to 19.0.10 then...?

@jotoeri
Copy link
Member Author

jotoeri commented Feb 24, 2021

@nickvergessen Is 19 ok? Or better 20? Unfortunately it depends a bit on this question, when we can start using it. 🙈

@nickvergessen
Copy link
Member

If it's up to me I would only put it in 21
you can check it manually in your app by validating a "forms-form" parameter and when valid use it, if not use highlight fallback

Ref. nextcloud/forms#789

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri force-pushed the enh/include_RichObject_forms branch from c69f712 to f02362e Compare March 1, 2021 13:01
@jotoeri
Copy link
Member Author

jotoeri commented Mar 1, 2021

Ah, that's sad. But ok. 🤷‍♂️ It's 21 again and i'll have a look onto this validation. 😉

@jotoeri
Copy link
Member Author

jotoeri commented Mar 1, 2021

/backport to stable21

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
Copy link
Member

rullzer commented Mar 1, 2021

Probably wildly off-topic. But is there a reason we need all this in core... wouldn't it be enough if apps can provide such things themselves?

@nickvergessen
Copy link
Member

The idea was to have "stable api versioning" with the nextcloud version so if a moible client supports a given version it also doesn't break with any of those parameters but handles them gracefully.

@rullzer
Copy link
Member

rullzer commented Mar 2, 2021

@nickvergessen you ok now to merge this?

@nickvergessen nickvergessen merged commit 1a724cb into master Mar 2, 2021
@nickvergessen nickvergessen deleted the enh/include_RichObject_forms branch March 2, 2021 09:56
@welcome
Copy link

welcome bot commented Mar 2, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants